URI.regex | Added IPv6 compatibility #1322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added basic recognition of IPv6 addresses to the regex by adding a second option the the host-part of the regex (starting with index 66+18 byte). Does not check syntax anyhow. Only checking for "[", "]" wrapping "any mass off" [a-fA-F0-9:].
With code by @SergioCrisostomo
|
This looks very nice! |
|
👍 Small change, does exactly what it should (syntax checking the IPv6 address would make it too slow for hardly any benefit). I can imagine it was not fun figuring the regex out, though. Thanks for adding the test as well. Also ++ on the style fix commit. |
SergioCrisostomo
added a commit
that referenced
this pull request
Sep 27, 2015
URI.regex | Added IPv6 compatibility
Closed
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #1318
Added basic recognition of IPv6 addresses to the regex by adding a second option the the host-part of the regex (starting with index 66+18 byte).
Does not check syntax anyhow. Only checking for "[", "]" wrapping "any mass off" [a-fA-F0-9:].